zalando-zmon / opentracing-utils

Convenient utilities for adding OpenTracing support in your python projects
MIT License
20 stars 8 forks source link

Add span_extractor argument to requests tracing #52

Closed Birne94 closed 3 years ago

Birne94 commented 3 years ago

We want to use this package to send traces from our services to lightstep. Currently, tracing for the requests library does not support passing a custom span extractor, which I added as part of this PR.

codecov[bot] commented 3 years ago

Codecov Report

Merging #52 (13243a2) into master (9c89e1f) will decrease coverage by 1.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   98.37%   97.29%   -1.09%     
==========================================
  Files           9        9              
  Lines         370      370              
==========================================
- Hits          364      360       -4     
- Misses          6       10       +4     
Impacted Files Coverage Δ
opentracing_utils/libs/_requests.py 100.00% <100.00%> (ø)
opentracing_utils/libs/_flask.py 97.05% <0.00%> (-2.95%) :arrow_down:
opentracing_utils/libs/_django.py 97.22% <0.00%> (-2.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c89e1f...13243a2. Read the comment docs.

Birne94 commented 3 years ago

I am not sure why the coverage for the flask and django integrations went down with this PR, I did not touch those.

pitr commented 3 years ago

👍

Birne94 commented 3 years ago

👍

Birne94 commented 3 years ago

@pitr Thanks for merging this! Is there a release planned for the near future or what is the release plan for this library?

pitr commented 3 years ago

plz +1 #53 to bump version

Birne94 commented 3 years ago

plz +1 #53 to bump version

done!

pitr commented 3 years ago

0.21.0 should be now out