Add enrich span callable for sqlalchemy trace

zalando-zmon / opentracing-utils

Convenient utilities for adding OpenTracing support in your python projects

MIT License

20 stars 8 forks source link

Add enrich span callable for sqlalchemy trace #57

Closed avi-city closed 3 years ago

avi-city commented 3 years ago

Hi,

Following issue #56 , since we needed to have such an option, I forked the library and implemented the enrich_span you suggested. Let me know what you think.

Thanks, Avi

mohabusama commented 3 years ago

@avi-city LGTM. I would suggest updating the README SqlAlchemy examples with a usage example of the new option. Can be right under the skip_span example.

avi-city commented 3 years ago

Added

mohabusama commented 3 years ago

👍

mohabusama commented 3 years ago

@pitr @vetinari can we merge this one and publish a new release?

pitr commented 3 years ago

:+1: