zalando-zmon / zmon-aws-agent

AWS API crawler to auto discover running services in your account
Apache License 2.0
11 stars 11 forks source link

Use instance metadata #121

Closed vetinari closed 4 years ago

vetinari commented 6 years ago

see http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-identity-documents.html ... this saves one API call

codecov[bot] commented 6 years ago

Codecov Report

Merging #121 into master will decrease coverage by 0.8%. The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   76.33%   75.53%   -0.81%     
==========================================
  Files           6        6              
  Lines         655      654       -1     
==========================================
- Hits          500      494       -6     
- Misses        155      160       +5
Impacted Files Coverage Δ
zmon_aws_agent/main.py 33.33% <0%> (-1.15%) :arrow_down:
zmon_aws_agent/aws.py 89.75% <100%> (-0.14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 059601e...f5b2f24. Read the comment docs.

vetinari commented 6 years ago

:+1:

pitr commented 4 years ago

not needed