zalando-zmon / zmon-aws-agent

AWS API crawler to auto discover running services in your account
Apache License 2.0
11 stars 11 forks source link

Match EIPs against DNS names and expose the latter in entity #127

Closed avaczi closed 6 years ago

avaczi commented 6 years ago

otherwise the postgresql_database entities won't work. Comes with tests.

codecov[bot] commented 6 years ago

Codecov Report

Merging #127 into master will increase coverage by 0.49%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   76.69%   77.19%   +0.49%     
==========================================
  Files           6        6              
  Lines         824      842      +18     
==========================================
+ Hits          632      650      +18     
  Misses        192      192
Impacted Files Coverage Ξ”
zmon_aws_agent/postgresql.py 84.37% <100%> (+2.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 0cd081b...af78a3a. Read the comment docs.

mohabusama commented 6 years ago

πŸ‘

avaczi commented 6 years ago

:+1:

mohabusama commented 6 years ago

Please resolve the conflicts - merging master should bring in OpenTracing support.

avaczi commented 6 years ago

:+1:

avaczi commented 6 years ago

:+1:

mohabusama commented 6 years ago

πŸ‘