search

zalando-zmon / zmon-aws-agent

AWS API crawler to auto discover running services in your account
Apache License 2.0
11 stars 11 forks source link

Added field to include information about certificate usage. #149

Closed arjunrn closed 5 years ago

arjunrn commented 5 years ago

ACM certificates have a InUseBy field which can be used to filter out certificates which are not in use and hence not automatically renewed.

Signed-off-by: Arjun Naik arjun.rn@gmail.com

codecov[bot] commented 5 years ago

Codecov Report

Merging #149 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files           7        7           
  Lines        1006     1006           
=======================================
  Hits          788      788           
  Misses        218      218
Impacted Files Coverage Δ
zmon_aws_agent/aws.py 89.6% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3273460...28f1f8b. Read the comment docs.

mohabusama commented 5 years ago

👍

arjunrn commented 5 years ago

:+1:

arjunrn commented 5 years ago

@mohabusama Can you merge this and create a release?