Handle invalid credentials issue

marek-obuchowicz commented 8 years ago

As a zmon-cli user given I have wrong credentials in zmon config file I want to get "invalid credentials" error message.

detailed info:

When ~/.zmon-cli.yaml has invalid credentials, zmon-cli does not report the problem with credentials correctly, but throws an exception not being helpful in finding the problem:

$ zmon entities
Traceback (most recent call last):
  File "/usr/local/bin/zmon", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.4/dist-packages/zmon_cli/main.py", line 610, in main
    cli()
  File "/usr/local/lib/python3.4/dist-packages/click/core.py", line 700, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.4/dist-packages/click/core.py", line 680, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.4/dist-packages/click/core.py", line 1027, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.4/dist-packages/click/core.py", line 1007, in invoke
    return Command.invoke(self, ctx)
  File "/usr/local/lib/python3.4/dist-packages/click/core.py", line 873, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.4/dist-packages/click/core.py", line 508, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.4/dist-packages/click/decorators.py", line 16, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.4/dist-packages/zmon_cli/main.py", line 371, in entities
    render_entities(output)
  File "/usr/local/lib/python3.4/dist-packages/zmon_cli/main.py", line 353, in render_entities
    s = sorted(e.keys())
AttributeError: 'str' object has no attribute 'keys'

hjacobs commented 8 years ago

:+1:

Jan-M commented 8 years ago

I believe with @a1exsh pull request this is closed

zalando-zmon / zmon-cli

Handle invalid credentials issue #4