zalando-zmon / zmon-cli

ZMON Command Line Interface
http://zmon.readthedocs.org/en/latest/developer/zmon-cli.html
Other
9 stars 9 forks source link

fix opentracing log_kv() arg #89

Closed vetinari closed 5 years ago

vetinari commented 5 years ago

must be a dict, not a set, otherwise we'd get something like

   File "/usr/local/lib/python3.6/dist-packages/opentracing-1.3.0-py3.6.egg/opentracing/span.py", line 211, in __exit__
     self.finish()
   File "/usr/local/lib/python3.6/dist-packages/basictracer/span.py", line 56, in finish
     self._tracer.record(self)
   File "/usr/local/lib/python3.6/dist-packages/basictracer/tracer.py", line 100, in record
     self.recorder.record_span(span)
   File "/usr/local/lib/python3.6/dist-packages/lightstep/recorder.py", line 184, in record_span
     event = log.key_values.get('event') or ''
 AttributeError: 'set' object has no attribute 'get'
codecov[bot] commented 5 years ago

Codecov Report

Merging #89 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   77.97%   77.97%           
=======================================
  Files          18       18           
  Lines        1158     1158           
=======================================
  Hits          903      903           
  Misses        255      255
Impacted Files Coverage Δ
zmon_cli/client.py 97.91% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01b1ab0...f090482. Read the comment docs.

vetinari commented 5 years ago

:+1:

rajatparida86 commented 5 years ago

👍