Closed drummerwolli closed 4 years ago
Merging #743 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #743 +/- ##
=========================================
Coverage 34.07% 34.07%
Complexity 108 108
=========================================
Files 182 182
Lines 4514 4514
Branches 425 425
=========================================
Hits 1538 1538
Misses 2863 2863
Partials 113 113
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b77e977...f10c8c1. Read the comment docs.
The interesting question: what does clicking the button really do? Does it only re-evaluates the alert condition on the latest available data point(s), or does it re-run the underlying check as well?
This was never clear to me. I'm not sure if this is even documented anywhere here: https://docs.zmon.io/en/latest/search.html?q=evaluate&check_keywords=yes&area=default
fa-sync-alt
doesn't exist in CSS, and I don't think 🔄 is the right icon for this. Original icon is good@pitr thanks, then "re-run of check" is accurate description. :+1:
Original icon is good
... I would disagree here. or at least make the neighboring icon different. two links having the same icon is confusing:
fa-sync-alt doesn't exist in CSS
: i took it from the font-awesome site. the pre-fix fa
indicated to me that font-awesome is used. what is the list of available icons?
icons.less is the font-awesome version we use. There is fa-refresh
or even better fa-repeat
. However, I don't think those a good icons. Both Trial run and Re-run do the same thing ultimately, they run the code right now. Perhaps Trial Run is the icon that should be changed, since it has an additional "playground" feel to it. I couldn't find anything fitting though.
closing as stale
make the link more clear to what it does.