zalando-zmon / zmon-controller

ZMON UI and REST API
https://docs.zmon.io/
Other
21 stars 17 forks source link

fix auth for users group #745

Closed alexkorotkikh closed 5 years ago

alexkorotkikh commented 5 years ago

Missing check for Users group re-added

vetinari commented 5 years ago

:+1:

codecov[bot] commented 5 years ago

Codecov Report

Merging #745 into master will decrease coverage by 0.17%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #745      +/-   ##
===========================================
- Coverage     35.37%   35.2%   -0.18%     
- Complexity      108     109       +1     
===========================================
  Files           186     186              
  Lines          4599    4568      -31     
  Branches        425     423       -2     
===========================================
- Hits           1627    1608      -19     
+ Misses         2855    2844      -11     
+ Partials        117     116       -1
Impacted Files Coverage Δ Complexity Δ
...ando/zauth/zmon/service/ZauthAuthorityService.java 61.53% <66.66%> (-5.13%) 3 <0> (ø)
.../zalando/zmon/service/impl/HistoryServiceImpl.java 46.57% <0%> (-7.8%) 0% <0%> (ø)
...org/zalando/zauth/zmon/config/ZauthProperties.java 38.46% <0%> (+3.84%) 5% <0%> (+1%) :arrow_up:
...org/zalando/zmon/controller/HistoryController.java 25% <0%> (+15%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cd3fbd...ff5f1a4. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #745 into master will increase coverage by 0.02%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #745      +/-   ##
===========================================
+ Coverage     35.37%   35.4%   +0.02%     
- Complexity      108     109       +1     
===========================================
  Files           186     186              
  Lines          4599    4604       +5     
  Branches        425     426       +1     
===========================================
+ Hits           1627    1630       +3     
- Misses         2855    2856       +1     
- Partials        117     118       +1
Impacted Files Coverage Δ Complexity Δ
...ando/zauth/zmon/service/ZauthAuthorityService.java 61.53% <66.66%> (-5.13%) 3 <0> (ø)
...org/zalando/zauth/zmon/config/ZauthProperties.java 38.46% <0%> (+3.84%) 5% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cd3fbd...ff5f1a4. Read the comment docs.

alexkorotkikh commented 5 years ago

👍

vetinari commented 5 years ago

:+1:

alexkorotkikh commented 5 years ago

@vetinari I didn't tested it (that's why it wasn't merged) so please be careful while deploying