zalando-zmon / zmon-controller

ZMON UI and REST API
https://docs.zmon.io/
Other
21 stars 17 forks source link

query params for querying AlertIDs for listFalsePositiveRates #748

Closed rajatparida86 closed 5 years ago

rajatparida86 commented 5 years ago

Use query params for getting AlertID list for listFalsePositiveRates instead of the request body

Signed-off-by: Rajat parida rajat.parida@zalando.de

codecov[bot] commented 5 years ago

Codecov Report

Merging #748 into master will increase coverage by 0.04%. The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #748      +/-   ##
============================================
+ Coverage      35.9%   35.94%   +0.04%     
- Complexity      109      112       +3     
============================================
  Files           190      190              
  Lines          4696     4704       +8     
  Branches        428      428              
============================================
+ Hits           1686     1691       +5     
- Misses         2891     2894       +3     
  Partials        119      119
Impacted Files Coverage Δ Complexity Δ
...mon/service/impl/FalsePositiveRateServiceImpl.java 63.46% <0%> (-1.25%) 0 <0> (ø)
...o/zmon/controller/FalsePositiveRateController.java 50% <50%> (ø) 0 <0> (?)
...ando/zauth/zmon/service/ZauthAuthorityService.java 64.7% <0%> (+3.16%) 6% <0%> (+3%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec0a64a...88e7038. Read the comment docs.

alexkorotkikh commented 5 years ago

👍

rajatparida86 commented 5 years ago

👍