zalando-zmon / zmon-controller

ZMON UI and REST API
https://docs.zmon.io/
Other
21 stars 17 forks source link

Remove auth check /grafana endpoint #750

Closed rajatparida86 closed 5 years ago

rajatparida86 commented 5 years ago

No need for auth for /grafana endpoint as it will be authenticated on Grafana side

Signed-off-by: Rajat parida rajat.parida@zalando.de

codecov[bot] commented 5 years ago

Codecov Report

Merging #750 into master will increase coverage by 0.2%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #750     +/-   ##
===========================================
+ Coverage     35.68%   35.89%   +0.2%     
  Complexity      109      109             
===========================================
  Files           190      190             
  Lines          4660     4736     +76     
  Branches        425      435     +10     
===========================================
+ Hits           1663     1700     +37     
- Misses         2880     2917     +37     
- Partials        117      119      +2
Impacted Files Coverage Δ Complexity Δ
...lando/github/zmon/config/GithubSecurityConfig.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...zalando/zauth/zmon/config/ZauthSecurityConfig.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...org/zalando/zmon/controller/HistoryController.java 14.28% <0%> (-10.72%) 0% <0%> (ø)
.../zalando/zmon/service/impl/HistoryServiceImpl.java 53.43% <0%> (+6.85%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21309e8...dab19be. Read the comment docs.

rajatparida86 commented 5 years ago

👍

alexkorotkikh commented 5 years ago

👍