search

zalando-zmon / zmon-controller

ZMON UI and REST API
https://docs.zmon.io/
Other
21 stars 17 forks source link

Add tier to check page #756

Closed alex-on-java closed 5 years ago

alex-on-java commented 5 years ago

Added criticality to the check definition page:

Screenshot 2019-10-15 at 12 44 53

Added criticality for every check in the checks list:

Screenshot 2019-10-15 at 12 44 33

Added explanation

Screenshot 2019-10-15 at 12 44 18

0139ac2b: eagleeye/ZMON#478 extend the check definition with check tier

6a18740e: eagleeye/ZMON#478 add tier to the UI

a0ea5cae: eagleeye/ZMON#478 add test for backend

33ae7456: eagleeye/ZMON#478 work on feedback

3bc36095: eagleeye/ZMON#478 change string to enum

remove unknown to avoid user's confusion add three more tests

d8a25ee0: eagleeye/ZMON#478 move tier to the main stats of the check

hide tier info fully in case there is no tiers in the system

717e7e6d: eagleeye/ZMON#478 fix tests

5adc2f49: eagleeye/ZMON#478 show tier without conditions

eaefe849: eagleeye/ZMON#478 revert condition plus add logging

4b0c451c: eagleeye/ZMON#478 extract private method to reuse it

c012aa5c: eagleeye/ZMON#478 add tier to the check's list

a6d3c653: eagleeye/ZMON#478 add tier to the check by id

e3ac5934: eagleeye/ZMON#478 add tier to the checks by teams

202bb7db: eagleeye/ZMON#478 add tier the list of checks on the frontend

6e498fbe: eagleeye/ZMON#478 hide tier in the list when there is no entity

139ee908: eagleeye/ZMON#478 change text of the popup

8cc0b881: eagleeye/ZMON#478 rename Tier to the Criticality

5bda7a75: eagleeye/ZMON#478 remove EMPTY, use Optional instead

8f299990: eagleeye/ZMON#478 use null, cause Optional requires extra lib for json

d4e81fb9: eagleeye/ZMON#478 change others to other according to playbook

codecov[bot] commented 5 years ago

Codecov Report

Merging #756 into master will increase coverage by 0.43%. The diff coverage is 50.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #756      +/-   ##
============================================
+ Coverage     35.71%   36.15%   +0.43%     
  Complexity      109      109              
============================================
  Files           192      193       +1     
  Lines          4751     4788      +37     
  Branches        435      437       +2     
============================================
+ Hits           1697     1731      +34     
- Misses         2932     2935       +3     
  Partials        122      122
Impacted Files Coverage Δ Complexity Δ
...org/zalando/zmon/service/impl/ZMonServiceImpl.java 28.35% <44.33%> (+3.55%) 0 <0> (ø) :arrow_down:
...n/api/domain/entity/specific/CheckTiersEntity.java 93.75% <93.75%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4323935...a549bc8. Read the comment docs.

alex-on-java commented 5 years ago

👍

alex-on-java commented 5 years ago

👍

alex-on-java commented 5 years ago

👍

pitr commented 5 years ago

:+1:

alexkorotkikh commented 5 years ago

👍

alex-on-java commented 5 years ago

👍