zalando-zmon / zmon-controller

ZMON UI and REST API
https://docs.zmon.io/
Other
21 stars 17 forks source link

Add Content-Type header to GET /api/v1/entities{,/*} #782

Closed vetinari closed 4 years ago

vetinari commented 4 years ago

so that clients depending on that header interpret the response as JSON.

Signed-off-by: Hanno Hecker hanno@zalando.de

codecov[bot] commented 4 years ago

Codecov Report

Merging #782 into master will increase coverage by <.01%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #782      +/-   ##
============================================
+ Coverage     28.85%   28.85%   +<.01%     
  Complexity      111      111              
============================================
  Files           265      265              
  Lines          6242     6241       -1     
  Branches        513      512       -1     
============================================
  Hits           1801     1801              
+ Misses         4316     4315       -1     
  Partials        125      125
Impacted Files Coverage Δ Complexity Δ
...a/org/zalando/zmon/controller/ZMonRestService.java 20.4% <ø> (ø) 0 <0> (ø) :arrow_down:
.../src/main/java/org/zalando/zmon/api/EntityApi.java 64.38% <66.66%> (-0.49%) 0 <0> (ø)
...java/org/zalando/zmon/api/domain/EntityObject.java 100% <0%> (+100%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79680ee...55798e0. Read the comment docs.

vetinari commented 4 years ago

:+1:

pitr commented 4 years ago

:+1: