search

zalando-zmon / zmon-worker

ZMON Python Worker
https://zmon.io/
Other
19 stars 41 forks source link

'NotaZmonTask' object has no attribute 'metric_cache_check_ids' #24

Closed hjacobs closed 8 years ago

hjacobs commented 8 years ago

I will NOT comment this bug... :speak_no_evil:

Compare https://github.com/zalando/zmon-worker/blob/master/zmon_worker_monitor/zmon_worker/tasks/notacelery_task.py#L1044 and https://github.com/zalando/zmon-worker/blob/master/zmon_worker_monitor/zmon_worker/tasks/notacelery_task.py#L1364

hjacobs commented 8 years ago

Fixed and released with https://registry.opensource.zalan.do/teams/stups/artifacts/zmon-worker/tags/cd89/scm-source

Jan-M commented 8 years ago

I was pretty sure we had one unit test that covered our "not a celery" task execution? so when it went from failed to fixed I thought I was good.

Will look at IDE options again to get stupid auto complete. That's what you ment or? :palm_tree: