Closed vetinari closed 6 years ago
Please add the exception log and error tag to post_trial_run
failure. Also would be useful to add span tag trial_run=True
for worker_task_processing
in case of trial run.
the tracing should be a different PR, right :)
@vetinari span enrichment can always accompany feature/bug implementation, so that they don't get forgotten 😉
Merging #342 into master will decrease coverage by
0.32%
. The diff coverage is40%
.
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
- Coverage 75.44% 75.12% -0.33%
==========================================
Files 79 79
Lines 5738 5748 +10
==========================================
- Hits 4329 4318 -11
- Misses 1409 1430 +21
Impacted Files | Coverage Δ | |
---|---|---|
zmon_worker_monitor/builtins/plugins/http.py | 97.93% <100%> (ø) |
:arrow_up: |
zmon_worker_monitor/workflow.py | 71.36% <100%> (-4.47%) |
:arrow_down: |
zmon_worker_monitor/zmon_worker/tasks/main.py | 74.69% <25%> (-0.86%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 84f6d90...7e7c5e5. Read the comment docs.
:+1:
:+1:
👍
they were not serialized properly