search

zalando-zmon / zmon-worker

ZMON Python Worker
https://zmon.io/
Other
19 stars 41 forks source link

cloudwatch - dimensions for zero floats, #347

Closed olevchyk closed 6 years ago

olevchyk commented 6 years ago

when cloudwatch metric has zero values by design 0.0, like number of errors, query() returns data with empty dimensions dict. Because: 

>>> False == 0.0
True
codecov[bot] commented 6 years ago

Codecov Report

Merging #347 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   75.14%   75.13%   -0.02%     
==========================================
  Files          79       79              
  Lines        5750     5750              
==========================================
- Hits         4321     4320       -1     
- Misses       1429     1430       +1
Impacted Files Coverage Δ
zmon_worker_monitor/builtins/plugins/cloudwatch.py 100% <100%> (ø) :arrow_up:
zmon_worker_monitor/zmon_worker/tasks/main.py 74.69% <0%> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bad7b6...4ff8126. Read the comment docs.

mohabusama commented 6 years ago

👍

vetinari commented 6 years ago

:+1: