Closed vetinari closed 6 years ago
Merging #352 into master will increase coverage by
0.85%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
+ Coverage 75.18% 76.03% +0.85%
==========================================
Files 79 79
Lines 5750 6171 +421
==========================================
+ Hits 4323 4692 +369
- Misses 1427 1479 +52
Impacted Files | Coverage Δ | |
---|---|---|
zmon_worker_monitor/builtins/plugins/scalyr.py | 96.84% <100%> (+0.37%) |
:arrow_up: |
zmon_worker_monitor/process_controller.py | 84.86% <0%> (-0.53%) |
:arrow_down: |
zmon_worker_monitor/zmon_worker/tasks/main.py | 78.85% <0%> (+4.15%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1e7f9c9...34dc48e. Read the comment docs.
:+1:
Why don't we set the default end=0
? since this is the expectation anyway.
👍
:+1:
this parameter specifies the number of minutes before now the end of the search time. When this is not given, the old behaviour of 24 hours (scalyr default) applies. Example to search for logs from 3 days ago to now is then
scalyr().logs(minutes=3*24*60, until=0)
fixes #349