zalando-zmon / zmon-worker

ZMON Python Worker
https://zmon.io/
Other
19 stars 41 forks source link

Check whether broken alert notifications prevents alert to pop up #37

Closed hjacobs closed 8 years ago

hjacobs commented 8 years ago

To be checked: broken notification settings (e.g. invalid syntax in https://docs.zmon.io/en/latest/user/alert-definitions.html#notifications) should not prevent the alert from popping up (e.g. on the dashboard).

mohabusama commented 8 years ago

I tested raising exception deliberately in send_notification, this did not prevent alerts from pop-up in dashboard. Mainly an exception is logged:

https://github.com/zalando-zmon/zmon-worker/blob/master/zmon_worker_monitor/zmon_worker/tasks/main.py#L1574

@hjacobs, Is there any other scenario to be covered?

hjacobs commented 8 years ago

I think that's fine, let's close this.