search

zalando-zmon / zmon-worker

ZMON Python Worker
https://zmon.io/
Other
19 stars 41 forks source link

Allow authentication to be passed to redis plugin #389

Closed olevchyk closed 5 years ago

olevchyk commented 5 years ago

This PR Allows authentication to be passed to redis plugin fixes https://github.com/zalando-zmon/zmon-worker/issues/385

codecov[bot] commented 5 years ago

Codecov Report

Merging #389 into master will increase coverage by 0.19%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   75.37%   75.56%   +0.19%     
==========================================
  Files          80       80              
  Lines        5917     5918       +1     
==========================================
+ Hits         4460     4472      +12     
+ Misses       1457     1446      -11
Impacted Files Coverage Δ
...n_worker_monitor/builtins/plugins/redis_wrapper.py 69.84% <100%> (+16.61%) :arrow_up:
zmon_worker_monitor/zmon_worker/common/tracing.py 75% <0%> (+8.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3371f4...5817c6d. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #389 into master will increase coverage by 0.19%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   75.37%   75.56%   +0.19%     
==========================================
  Files          80       80              
  Lines        5917     5918       +1     
==========================================
+ Hits         4460     4472      +12     
+ Misses       1457     1446      -11
Impacted Files Coverage Δ
...n_worker_monitor/builtins/plugins/redis_wrapper.py 69.84% <100%> (+16.61%) :arrow_up:
zmon_worker_monitor/zmon_worker/tasks/main.py 75.57% <0%> (+0.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3371f4...6055ab1. Read the comment docs.

mohabusama commented 5 years ago

Thanks @olevchyk !

mohabusama commented 5 years ago

👍

vetinari commented 5 years ago

:+1: