search

zalando-zmon / zmon-worker

ZMON Python Worker
https://zmon.io/
Other
19 stars 41 forks source link

fix empty env var passed as user #403

Closed vetinari closed 5 years ago

vetinari commented 5 years ago

this may happen if the docker image is wrapping one where the env is set and we need to override it

mohabusama commented 5 years ago

👍

vetinari commented 5 years ago

:+1:

codecov[bot] commented 5 years ago

Codecov Report

Merging #403 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   75.31%   75.33%   +0.01%     
==========================================
  Files          80       80              
  Lines        5952     5952              
==========================================
+ Hits         4483     4484       +1     
+ Misses       1469     1468       -1
Impacted Files Coverage Δ
...n_worker_monitor/zmon_worker/notifications/mail.py 78.44% <100%> (ø) :arrow_up:
zmon_worker_monitor/zmon_worker/tasks/main.py 74.64% <0%> (+0.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5df66f3...b120543. Read the comment docs.