Closed vetinari closed 5 years ago
Merging #411 into master will decrease coverage by
<.01%
. The diff coverage is71.42%
.
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
- Coverage 75.35% 75.34% -0.01%
==========================================
Files 80 80
Lines 5964 5971 +7
==========================================
+ Hits 4494 4499 +5
- Misses 1470 1472 +2
Impacted Files | Coverage Δ | |
---|---|---|
zmon_worker_monitor/zmon_worker/tasks/main.py | 74.51% <71.42%> (-0.03%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f2f05ee...78e9fce. Read the comment docs.
will adding new fields break data service due to unrecognized fields?
no - and in doubt, there's https://github.com/zalando-zmon/zmon-data-service/pull/135 also
:+1:
ie so DS needs to be deployed first
:+1:
this needs to be done here, only here the comnplete entity is available