zalando-zmon / zmon-worker

ZMON Python Worker
https://zmon.io/
Other
19 stars 41 forks source link

add job-metrics data to check result #411

Closed vetinari closed 5 years ago

vetinari commented 5 years ago

this needs to be done here, only here the comnplete entity is available

codecov[bot] commented 5 years ago

Codecov Report

Merging #411 into master will decrease coverage by <.01%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   75.35%   75.34%   -0.01%     
==========================================
  Files          80       80              
  Lines        5964     5971       +7     
==========================================
+ Hits         4494     4499       +5     
- Misses       1470     1472       +2
Impacted Files Coverage Δ
zmon_worker_monitor/zmon_worker/tasks/main.py 74.51% <71.42%> (-0.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2f05ee...78e9fce. Read the comment docs.

pitr commented 5 years ago

will adding new fields break data service due to unrecognized fields?

vetinari commented 5 years ago

no - and in doubt, there's https://github.com/zalando-zmon/zmon-data-service/pull/135 also

vetinari commented 5 years ago

:+1:

pitr commented 5 years ago

ie so DS needs to be deployed first

pitr commented 5 years ago

:+1: