search

zalando-zmon / zmon-worker

ZMON Python Worker
https://zmon.io/
Other
19 stars 41 forks source link

kubernetes: use a kwarg for check_id #419

Closed aermakov-zalando closed 5 years ago

aermakov-zalando commented 5 years ago

propartial doesn't raise any errors if a protected argument is not a keyword one, but it won't be handled correctly. Users that do kubernetes('foo') instead of kubernetes(namespace='foo') will not get any results.

codecov[bot] commented 5 years ago

Codecov Report

Merging #419 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   75.16%   75.18%   +0.01%     
==========================================
  Files          80       80              
  Lines        5952     5952              
==========================================
+ Hits         4474     4475       +1     
+ Misses       1478     1477       -1
Impacted Files Coverage Δ
zmon_worker_monitor/builtins/plugins/kubernetes.py 100% <100%> (ø) :arrow_up:
zmon_worker_monitor/zmon_worker/tasks/main.py 74.61% <0%> (+0.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10d91c6...ff486e1. Read the comment docs.

aermakov-zalando commented 5 years ago

👍

vetinari commented 5 years ago

:+1: