Closed amedhat3 closed 4 years ago
Merging #423 into master will increase coverage by
0.04%
. The diff coverage is82.35%
.
@@ Coverage Diff @@
## master #423 +/- ##
=========================================
+ Coverage 75.15% 75.2% +0.04%
=========================================
Files 80 81 +1
Lines 5954 5988 +34
=========================================
+ Hits 4475 4503 +28
- Misses 1479 1485 +6
Impacted Files | Coverage Δ | |
---|---|---|
zmon_worker_monitor/builtins/plugins/bigquery.py | 82.35% <82.35%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ce70713...a14fa1e. Read the comment docs.
LGTM
:+1:
👍
Create a wrapper around BigQuery, it invokes the query function and waits for the result to be returned. This plugin helps us to monitor the functional metrics of the applications, like conversion rate and successful searches, which can't be monitored from the application logs/metrics API, fixes https://github.com/zalando-zmon/zmon-worker/issues/115.
A decrypted service key need to be sent to the wrapper to be able to access BigQuery
Ran the tests using an external docker file, thanks for the hint (Alexey Ermakov)