zalando-zmon / zmon-worker

ZMON Python Worker
https://zmon.io/
Other
19 stars 41 forks source link

Monkey-patch pykube to be compatible with 1.16 #432

Closed aermakov-zalando closed 4 years ago

aermakov-zalando commented 4 years ago

ZMON still uses a very old Python version, so it's impossible to update pykube to a version that's compatible with 1.16. Let's just monkey-patch its objects instead.

codecov[bot] commented 4 years ago

Codecov Report

Merging #432 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   75.31%   75.35%   +0.03%     
==========================================
  Files          81       81              
  Lines        6024     6029       +5     
==========================================
+ Hits         4537     4543       +6     
+ Misses       1487     1486       -1
Impacted Files Coverage Δ
zmon_worker_monitor/builtins/plugins/kubernetes.py 100% <100%> (ø) :arrow_up:
zmon_worker_monitor/process_controller.py 84.57% <0%> (-0.52%) :arrow_down:
zmon_worker_monitor/zmon_worker/tasks/main.py 74.61% <0%> (+0.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a44019...f2717ed. Read the comment docs.

mikkeloscar commented 4 years ago

:+1:

aermakov-zalando commented 4 years ago

👍

pitr commented 4 years ago

:+1: