search

zalando-zmon / zmon-worker

ZMON Python Worker
https://zmon.io/
Other
19 stars 41 forks source link

use timeseries queries instead of numeric queries #435

Closed pheanex closed 4 years ago

pheanex commented 4 years ago

@anton-ryzhov @christianberg @femueller @astarnell Please review Will convert to PR if we agree Please also check the "align" as this differs from timeseries (it does not seem to be consistent with "function")

codecov[bot] commented 4 years ago

Codecov Report

Merging #435 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #435      +/-   ##
=========================================
+ Coverage    75.4%   75.4%   +<.01%     
=========================================
  Files          81      81              
  Lines        6047    6039       -8     
=========================================
- Hits         4560    4554       -6     
+ Misses       1487    1485       -2
Impacted Files Coverage Δ
zmon_worker_monitor/builtins/plugins/scalyr.py 96.03% <100%> (-0.3%) :arrow_down:
zmon_worker_monitor/zmon_worker/tasks/main.py 74.71% <0%> (+0.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee94786...a704c86. Read the comment docs.

pheanex commented 4 years ago

:+1:

femueller commented 4 years ago

:+1: