OCTO-1502: cleanup of call chains

zalando / expan

Open-source Python library for statistical analysis of randomised control trials (A/B tests)

MIT License

335 stars 50 forks source link

Closed gbordyugov closed 7 years ago

gbordyugov commented 7 years ago

OCTO-1502

introducing make_delta() to hide statistics parameters in the call chains.

gbordyugov commented 7 years ago

hmm, it fails with minor diffs in floating point constants in low-level bayesian functions that I didn't touch...

mkolarek commented 7 years ago

I would say that the difference is negligible, from my point of view you can simply update the unit test values.

gbordyugov commented 7 years ago

I'm running tox-based tests locally in order to reproduce (just used runtests before)

shansfolder commented 7 years ago

Thank you Grisha. It looks good! See my comments above for a few small suggestions.

coveralls commented 7 years ago

Changes Unknown when pulling f8f2a0026b67133592872503b8663744623e9583 on gbordyugov:introducing-make-delta into on zalando:dev.

coveralls commented 7 years ago

Changes Unknown when pulling f8f2a0026b67133592872503b8663744623e9583 on gbordyugov:introducing-make-delta into on zalando:dev.

coveralls commented 7 years ago

Changes Unknown when pulling f8f2a0026b67133592872503b8663744623e9583 on gbordyugov:introducing-make-delta into on zalando:dev.