Added try-finally block for the compulsory clean-up of .pkl compiled models

zalando / expan

Open-source Python library for statistical analysis of randomised control trials (A/B tests)

MIT License

335 stars 50 forks source link

Added try-finally block for the compulsory clean-up of .pkl compiled models #130

Closed daryadedik closed 7 years ago

coveralls commented 7 years ago

Coverage increased (+0.03%) to 79.19% when pulling 6527ef6f609b540eb3ef885227febfa741e7a540 on darya_expan into 0454b8a3c0f5110ba117f8e861bb254564325675 on dev.

gbordyugov commented 7 years ago

I am just wondering what the purpose of this PR was.

daryadedik commented 7 years ago

@gbordyugov it's just small improvement to the cleaning up of compiled stan models. We need to delete compiled .pkl files no matter the script failed or not. Otherwise it should be deleted by hand.

gbordyugov commented 7 years ago

thanks!