Performance improvement of variant comparison

zalando / expan

Open-source Python library for statistical analysis of randomised control trials (A/B tests)

MIT License

331 stars 50 forks source link

Performance improvement of variant comparison #223

Closed shansfolder closed 6 years ago

shansfolder commented 6 years ago

@igusher @gbordyugov @aaron-mcdaid-zalando It looks good to me. Please confirm to merge and deploy this version.

coveralls commented 6 years ago

Coverage increased (+0.2%) to 91.443% when pulling cb85adc118f7f59669090ba0a5e9fa199fe67e23 on performance-impro into cd485c57acc4330052d4e4262b290bd563317187 on master.

igusher commented 6 years ago

:+1:

shansfolder commented 6 years ago

@aaron-mcdaid-zalando I've made a commit to handle nans now.

aaron-mcdaid-zalando commented 6 years ago

I see the current state includes lots of other changes for min_observations and so on. I'm not happy with putting multiple features into one PR, especially given our current problems with quality/testing/correctness

This should be a one-line change

shansfolder commented 6 years ago

solved in #224