search

zalando / expan

Open-source Python library for statistical analysis of randomised control trials (A/B tests)
MIT License
335 stars 50 forks source link

Why features are iterated in a for loop? #243

Closed igusher closed 6 years ago

igusher commented 6 years ago

https://github.com/zalando/expan/blob/master/expan/core/experiment.py#L87

I didn't quite get this for loop. As far as I understand only last feature filter will be applied and all other are ignored? Do I get it right?

shansfolder commented 6 years ago

@igusher It was designed to support multiple feature at the same time. e.g. female chrome user. So all features defined in the instance of StatisticalTest will be applied.

In Octopus, we only initialize each StatisticalTest with only one feature,

igusher commented 6 years ago

I see, thanks