zalando / expan

Open-source Python library for statistical analysis of randomised control trials (A/B tests)
MIT License
334 stars 50 forks source link

Refactoring/move analysis logic inside statistical test #247

Closed igusher closed 5 years ago

igusher commented 5 years ago

Now the meat of it.

PR is based on another one - so there are duplicated changed. https://github.com/zalando/expan/pull/246

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 92.565% when pulling 5ef3c37743a2d2e5aa9e1a43354a433962a8fa71 on igusher:refactoring/move-analysis-logic-inside-statistical-test into 99908d1482fe8cd88e7828b29408bd200adb4b2d on zalando:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 92.565% when pulling 5ef3c37743a2d2e5aa9e1a43354a433962a8fa71 on igusher:refactoring/move-analysis-logic-inside-statistical-test into 99908d1482fe8cd88e7828b29408bd200adb4b2d on zalando:master.

igusher commented 5 years ago

Temporarily closing it, to avoid confusion, let's review #246 first to reduce efforts by doing it in small chunks.