Use interactive mode for darwin

zalando / go-keyring

Cross-platform keyring interface for Go

MIT License

815 stars 82 forks source link

Use interactive mode for darwin #26

Closed snorberhuis closed 1 year ago

snorberhuis commented 6 years ago

This fixes issue #24 . I needed to implement this library for a project and saw this open security issue. Because that project needs to ship I made a fix for it.

I tried to think of a way of testing this but I am ensure how to add an automatic test for it and I see no other tests that test on darwin.

Please let me know if I can make improvements to code style.

marco-m commented 1 year ago

@Piccirello is it correct that this PR can be closed, since an alternative implementation to solve the same problem has been merged from PR #65 ?

Piccirello commented 1 year ago

Indeed, this PR is no longer needed.