search

zalando / go-keyring

Cross-platform keyring interface for Go
MIT License
815 stars 82 forks source link

add support for multiline passwords on all platforms #35

Closed rremer closed 5 years ago

rremer commented 5 years ago

Bugfix for multiline password encoding on OSX. A workaround would be the feature development of certificate stores instead of password store types, but this fix is still worth having IMHO.

tl;dr is that OSX will hex encode passwords if there are certain characters in the stream, newlines are the one I stumbled upon. Gnome-keyring doesn't have this, so multiline passwords still come out un-encoded. I have not tested windows, but am hoping your CI will pick that up if work is needed so I don't have to install a vm :)

mikkeloscar commented 5 years ago

@rremer thanks for the PR, looks good to me. If you could just signoff your commit (see the failing check) then we can get this merged!

rremer commented 5 years ago

Thanks for the review @mikkeloscar . Today I learned that passing --signoff is a valid DCO?!? Torvald's way of dealing with laywers :)

mikkeloscar commented 5 years ago

:+1:

njuettner commented 5 years ago

👍

szuecs commented 5 years ago

:+1: