search

zalando / go-keyring

Cross-platform keyring interface for Go
MIT License
847 stars 85 forks source link

[RFC] add kwalled (kde) backend and use it if available #52

Closed bearsh closed 2 years ago

bearsh commented 3 years ago

the kwallet (kde) backend communicates through dbus with the kwalletd. it is modeled after the qtkeychain implementation [1]. like qtkeychain, the keyring backend tries to get the kwallet's 'networkWallet' if this fails the 'secret service' is used as before. kwallet is tried first as the 'secrets service' may exists on systems running kde but it's very unlikely kwallet is running on non kde systems.

[1] https://github.com/frankosterfeld/qtkeychain

SoMuchForSubtlety commented 2 years ago

Hi, is this PR still being worked on? If not I could take over if that's OK for you.

I recently switched to this library from https://github.com/99designs/keyring due to macOS issues, and KWalled support is the only thing I'm missing.^1

bearsh commented 2 years ago

Hi, is this PR still being worked on? If not I could take over if that's OK for you.

Sure just do it :smile: (In the past I though I would probaly need to lib for a project but it turned out to be wrong, so I lost my motivation.)

Let me know once you've opened a new PR so I can close this one...

bearsh commented 2 years ago

closed in favor of #66