search

zalando / go-keyring

Cross-platform keyring interface for Go
MIT License
881 stars 86 forks source link

fix: fix adding large keys truncates #85

Closed mfmarche closed 2 years ago

mfmarche commented 2 years ago

fixes #84

Appears to be an issue with darwin interactive mode of /usr/bin/security, where the key is limited in size. Using non-interactive and invoking command directly functions correctly.

mikkeloscar commented 2 years ago

This way we revert a previous change intended to prevent exposing passwords in the system process list see: https://github.com/zalando/go-keyring/pull/65

I think supporting such large keys should only be done if it can also be done in a way which doesn't expose the passwords.

mfmarche commented 2 years ago

thanks @mikkeloscar for pointing that out. I can close this as its not required, I also found out that windows is limited to 512 byte values, so to keep platform functionality similiar I see no reason to support larger values anymore.