search

zalando / go-keyring

Cross-platform keyring interface for Go
MIT License
811 stars 82 forks source link

Fix Windows crash by bumping wincred #91

Closed mislav closed 1 year ago

mislav commented 1 year ago

For some Go applications, reading a stored credential from wincred could result in a crash because both the returned credential pointer and the error value would be nil, even though the credential technically exists in wincred storage. This was fixed upstream in the wincred library.

⚠️ Note that the minimum Go version required by danieljoos/wincred is now 1.18. The appveyor build fails as a result due to its go version go1.13.3

Fixes https://github.com/zalando/go-keyring/issues/53

mikkeloscar commented 1 year ago

Thanks! @mislav

mikkeloscar commented 1 year ago

Will remove appvoyer in #93 and fix the FreeBSD build in #94

szuecs commented 1 year ago

Ah no close/reopen does not work, you have to fetch and rebase on master branch. We merged all the mentioned PRs.

mikkeloscar commented 1 year ago

I have rebased the PR

mikkeloscar commented 1 year ago

:+1:

demonCoder95 commented 1 year ago

👍