search

zalando / intellij-swagger

A plugin to help you easily edit Swagger and OpenAPI specification files inside IntelliJ IDEA
https://plugins.jetbrains.com/plugin/8347
MIT License
1.17k stars 74 forks source link

Support completion from workspace files #307

Closed gayanper closed 2 years ago

gayanper commented 4 years ago

This will show definition in other workspace files in ref completions for definitions.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.1%) to 91.282% when pulling 0cf5a41031f30d4d0a4a40fc57851c51e28dda56 on gayanper:ref_completions into 372e5a26b58212525390a09448be2239a134598a on zalando:master.

gayanper commented 4 years ago

@zeitlinger and @tkrop Please review my changes and let me know what you think.

Please let me know what do you think about the PR. I’m not really sure its a good idea to start file paths with ./. Let me know your thoughts

gayanper commented 4 years ago

@zeitlinger is this repo live and accepting PRs ?

gayanper commented 4 years ago

Can these PRs get some feedback ? I would really like to get this merged into the product rather than starting up my own fork doing builds. @semonte @maxim-tschumak @tkrop please help me to get this changes in. I’m trying hard here because this is great potential tool when it comes swagger spec editing.

tkrop commented 4 years ago

@gayanper thanks for the PR.

I'm not sure what this feature is about. Can you explain your exact use case and what additional references are made available here?

gayanper commented 4 years ago

@tkrop When you split swagger spec in the multiple files, you might want to add a reference to a resource in another file. This PR will list resources from all the files inside the current module the current editing file belongs to. Something similar to https://apihandyman.io/writing-openapi-swagger-specification-tutorial-part-8-splitting-specification-file/

shaburov commented 3 years ago

A year will soon pass, and the problem has not been resolved. The plugin is developing in the best traditions of a bloody enterprise. Good strategy, effective and users are happy.

tkrop commented 3 years ago

@shaburov Sorry, the year. I'm actually only waiting for the initiator to add the security switch to turn this feature on and off as a safeguard. If you are willing to take this over, I can merge it tomorrow.

tfrauenstein commented 2 years ago

Closed, since user test with bigger projects have not been executed to mitigate risk of bad user experience due to autocomplete search delays.