search

zalando / intellij-swagger

A plugin to help you easily edit Swagger and OpenAPI specification files inside IntelliJ IDEA
https://plugins.jetbrains.com/plugin/8347
MIT License
1.17k stars 74 forks source link

Bump org.jetbrains.intellij from 1.13.2 to 1.13.3 #349

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps org.jetbrains.intellij from 1.13.2 to 1.13.3.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
asaarilahti commented 1 year ago

https://github.com/JetBrains/gradle-intellij-plugin/issues/1359

Jackson still uses 1.3.x.

cberg-zalando commented 1 year ago

@dependabot rebase

dependabot[bot] commented 1 year ago

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

cberg-zalando commented 1 year ago

@dependabot recreate

asaarilahti commented 1 year ago

JetBrains/gradle-intellij-plugin#1359

The failure is:

'void org.yaml.snakeyaml.parser.ParserImpl.<init>(org.yaml.snakeyaml.reader.StreamReader, org.yaml.snakeyaml.LoaderOptions)'
java.lang.NoSuchMethodError: 'void org.yaml.snakeyaml.parser.ParserImpl.<init>(org.yaml.snakeyaml.reader.StreamReader, org.yaml.snakeyaml.LoaderOptions)'
    at com.fasterxml.jackson.dataformat.yaml.YAMLParser.<init>(YAMLParser.java:204)
    at com.fasterxml.jackson.dataformat.yaml.YAMLFactory._createParser(YAMLFactory.java:505)

That constructor seems to have been added in SnakeYaml 1.32: https://bitbucket.org/snakeyaml/snakeyaml/commits/72dfa9f1074abe2b8a6c8776bee4476b0aed02e3.

However, there's an old version of SnakeYaml bundled in IDEA. There's app.jar:

Screenshot 2023-04-25 at 17 09 01

Which has: 'Screenshot 2023-04-25 at 17 09 31

As mentioned in https://github.com/JetBrains/gradle-intellij-plugin/issues/1359, the likely cause is https://github.com/JetBrains/gradle-intellij-plugin/issues/473.

cberg-zalando commented 1 year ago

I mixed this up. I somehow thought it was related to the Jackson version.

asaarilahti commented 1 year ago

I mixed this up. I somehow thought it was related to the Jackson version.

I actually commented about Jackson version above (https://github.com/zalando/intellij-swagger/pull/349#issuecomment-1495814287), as I thought this is related to different SnakeYaml versions between Jackson and IntelliJ. But that was not the case.

cberg-zalando commented 1 year ago

Okay. Then my memory is not as bad as I thought. :smile:

dependabot[bot] commented 1 year ago

Superseded by #372.