Closed ePaul closed 1 year ago
I didn't specifically check whether any tests are affected – looking for "will skip sending obsolete data" didn't show other locations than the one modified here, so I suppose there are no tests for this. Same for documentation.
:+1:
:+1:
Hm: [ant:checkstyle] [ERROR] /workspace/api-consumption/src/main/java/org/zalando/nakadi/service/subscription/state/PartitionData.java:189: Line is longer than 120 characters (found 133). [LineLength]
Wonder how it passed the build earlier? :)
One-line summary
Extend log message to include the offset just compared.
Description
@tanvir002700 noted in an internal chat a situation (running Nakadi locally) where this error message is raised. When trying to look into it, I noticed that the offset printed as part of the error message is not too helpful: Nakadi is comparing
offset
andsentOffset
, but was loggingsentOffset
andcommitOffset
.This PR adds
offset
to the log message, hopefully making it easier to debug problems when this occurs.Review
Deployment Notes
These should highlight any db migrations, feature toggles, etc.