zalando / nakadi

A distributed event bus that implements a RESTful API abstraction on top of Kafka-like queues
https://nakadi.io
MIT License
952 stars 292 forks source link

ZDLK-5077 update the validations for datalake annotations #1527

Closed adrianafirutanasie closed 1 year ago

adrianafirutanasie commented 1 year ago

One-line summary

Zalando ticket : https://jira.zalando.net/browse/ZDLK-5077 extension of Validate datalake annotations (#1509 )

Description

The validations for annotations were extended to meet these constraints https://docs.google.com/document/d/1YkX9VYxntvAQj0qSCVVpgqLxOoAv4HZhJIyh7EWMwg8/edit#

tor-vs-floki commented 1 year ago

👍

eliseealex commented 1 year ago

I fixed comments in the: https://github.com/eliseealex/nakadi/commit/5e135fb6c5722ef06f65997cfa3665d44e9621c1, but I think I can't change this PR, should I create a new one?

I couldn't change Adriana's repo.

1u0 commented 1 year ago

@eliseealex, I've pushed your commit change to @adrianafirutanasie fork (this PR's branch). You won't need to open another PR.

1u0 commented 1 year ago

:+1:

eliseealex commented 1 year ago

👍

darkknight100 commented 1 year ago

👍

ovidiu-eremia commented 1 year ago

:+1:

a1exsh commented 1 year ago

:+1:

salman-ghauri commented 1 year ago

👍

samizzy commented 1 year ago

:+1: