search

zalando / nakadi

A distributed event bus that implements a RESTful API abstraction on top of Kafka-like queues
https://nakadi.io
MIT License
952 stars 293 forks source link

extend the validations: retention period mandatory for materialisatio… #1543

Closed adrianafirutanasie closed 5 months ago

adrianafirutanasie commented 11 months ago

extend the validations: retention period mandatory for materialisation opt-in

One-line summary

Zalando ticket : https://jira.zalando.net/browse/ZDLK-5203

Description

We have extended the validations for the annotations field, to make the retention period field mandatory when the materialise_events field has value "on"

Review

a1exsh commented 11 months ago

:+1:

1u0 commented 11 months ago

:+1:

rishiraj88 commented 11 months ago

👍

eliseealex commented 11 months ago

Note: please don't roll out, it is breaking backward compatibility right now. There should be an exception for the affected events.

adyach commented 5 months ago

@eliseealex there is work in this direction in different PR https://github.com/zalando/nakadi/pull/1587

eliseealex commented 5 months ago

Comments are addressed in the: https://github.com/zalando/nakadi/pull/1543, Danylo had no access to this PR, could you close it and use the new one instead.