zalando / nakadi

A distributed event bus that implements a RESTful API abstraction on top of Kafka-like queues
https://nakadi.io
MIT License
952 stars 293 forks source link

Add unprocessable event policy on consumption #1561

Closed a1exsh closed 9 months ago

a1exsh commented 9 months ago

This allows the user to choose between the current implementation of skipping the unprocessable events, or sending those events to the dead letter queue.

a1exsh commented 9 months ago

One other thing to take care of is, either to have this dlq event type created or somehow disallow DEAD_LETTER_QUEUE policy now.

Right, this remains to be followed-up on. I tend to keep the policy allowed even if the event type is not present — that's not harmful, as long as no one actually depends on it working.

samizzy commented 9 months ago

:+1:

a1exsh commented 9 months ago

@samizzy @1u0 I've included the DLQ store event type definition in the app resources — that enables local testing and makes the code shorter as well. Please have another look.

samizzy commented 9 months ago

:+1:

a1exsh commented 9 months ago

:+1: