search

zalando / pg_view

Get a detailed, real-time view of your PostgreSQL database and system metrics
https://pypi.python.org/pypi/pg-view
Other
496 stars 49 forks source link

Connect using Connection Service File #65

Closed feikesteenbergen closed 7 years ago

feikesteenbergen commented 8 years ago

For those who already have their Connection Service Files setup, it is useful not to have to specify the configuration file. By connection using the service= format we delegate all the resolving of service file locations to libpq.

a1exsh commented 8 years ago

:+1:

LappleApple commented 7 years ago

@a1exsh @alexeyklyukin Is it ok to update the branch and then merge?

feikesteenbergen commented 7 years ago

I can't update this branch myself anymore, should I close and reopen a PR to rebase?

LappleApple commented 7 years ago

@feikesteenbergen I can update it if @alexeyklyukin approves it, I have admin SUPERPOWERS

LappleApple commented 7 years ago

@alexeyklyukin Hey can we move forward with @feikesteenbergen's PR?

alexeyklyukin commented 7 years ago

@feikesteenbergen it needs to be updated to change pg_view/init.py instead of pg_view.py, as I don't know the way to do it via conflict resolution (the main pg_view.py is split into multiple files). If you have time to do it - please, do, otherwise I will take care of it.