zalando / pg_view

Get a detailed, real-time view of your PostgreSQL database and system metrics
https://pypi.python.org/pypi/pg-view
Other
496 stars 49 forks source link

AttributeError: 'PgstatCollector' object has no attribute 'format' #66

Open sebastianwebber opened 8 years ago

sebastianwebber commented 8 years ago

Hi There,

There is some configuration to fix this error? pg_view work by less than 30 seconds, then crash:

[root@server ~]# pg_view -U postgres -p 9999
Traceback (most recent call last):
  File "/bin/pg_view", line 3432, in main
    loop(collectors, consumer, groups, output_method)
  File "/bin/pg_view", line 2748, in loop
    curses.wrapper(do_loop, groups, output_method, collectors, consumer)
  File "/usr/lib64/python2.7/curses/wrapper.py", line 43, in wrapper
    return func(stdscr, *args, **kwds)
  File "/bin/pg_view", line 2816, in do_loop
    process_single_collector(st)
  File "/bin/pg_view", line 2845, in process_single_collector
    st.refresh()
  File "/bin/pg_view", line 1196, in refresh
    proc_data = self._read_proc(pid, is_backend, is_active)
  File "/bin/pg_view", line 1253, in _read_proc
    result['uss'] = self._get_memory_usage(pid)
  File "/bin/pg_view", line 1275, in _get_memory_usage
    self.format(pid), e))
AttributeError: 'PgstatCollector' object has no attribute 'format'

About my enviroment:

[root@server ~]# python --version
Python 2.7.5
[root@server ~]# rpm -qa | grep postgresql
postgresql93-libs-9.3.14-1PGDG.rhel7.x86_64
postgresql93-contrib-9.3.14-1PGDG.rhel7.x86_64
postgresql93-9.3.14-1PGDG.rhel7.x86_64
postgresql93-server-9.3.14-1PGDG.rhel7.x86_64
[root@server ~]# rpm -qa | grep pg_view
pg_view-1.3.0-1.el7.noarch

Any ideias?

a1exsh commented 8 years ago

@sebastianwebber this is a typo, thank you for spotting it. The fix is in #67.

hjacobs commented 7 years ago

@a1exsh I ran into the same bug today in one of our data centers... :disappointed:


postgres@xxxx01:~$ pg_view
Traceback (most recent call last):
  File "/data/postgres/bin/pg_view.py", line 3525, in main
    loop(collectors, consumer, groups, output_method)
  File "/data/postgres/bin/pg_view.py", line 2823, in loop
    curses.wrapper(do_loop, groups, output_method, collectors, consumer)
  File "/usr/lib/python2.7/curses/wrapper.py", line 43, in wrapper
    return func(stdscr, *args, **kwds)
  File "/data/postgres/bin/pg_view.py", line 2891, in do_loop
    process_single_collector(st)
  File "/data/postgres/bin/pg_view.py", line 2921, in process_single_collector
    st.refresh()
  File "/data/postgres/bin/pg_view.py", line 1215, in refresh
    proc_data = self._read_proc(pid, is_backend, is_active)
  File "/data/postgres/bin/pg_view.py", line 1272, in _read_proc
    result['uss'] = self._get_memory_usage(pid)
  File "/data/postgres/bin/pg_view.py", line 1294, in _get_memory_usage
    self.format(pid), e))
AttributeError: 'PgstatCollector' object has no attribute 'format'