zalando / pg_view

Get a detailed, real-time view of your PostgreSQL database and system metrics
https://pypi.python.org/pypi/pg-view
Other
494 stars 49 forks source link

PG 10 issues #83

Closed erthalion closed 7 years ago

erthalion commented 7 years ago

Hello,

I tried to use pg_view on PG10, and found two issues:

if val is not None and len(val) >= 2:
    version = float(val)
else:
    dbname = get_dbname_from_path(pg_dir)
    postmasters[pg_dir] = [pid, version, dbname]

Of course it's easy to fix them, but I'm not sure how to do it in a backward compatible way.

LappleApple commented 7 years ago

Hello @erthalion, would you be up for making a bug fix/PR here? Then we can review and get this fixed faster for you.

erthalion commented 7 years ago

From what I see #84 should be enough for the "pg_wal" part, and we can forget about an issue with PG_VERSION, since on the current PG10 beta1 everything is fine.

alexeyklyukin commented 7 years ago

Fixed in #84