Logical backup secret results in duplicate environment keys

nickmansrob commented 3 months ago

Please, answer some short questions which should help us to understand your problem / question better?

Which image of the operator are you using? Helm: postgres-operator:v1.12.2
Where do you run it - cloud or metal? Kubernetes or OpenShift? Bare Metal K3s
Are you running Postgres Operator in production? almost
Type of issue? [Bug report, question, feature request, etc.] Bug report

When generating the cronjob for the logical backup when using Azure, the account key gets fetched form the OperatorConfiguration, even when it's empty. This happens here. I pass it through a SOPS encrypted secret, and this results in a duplicate environment entry in the cronjob with following kubernetes warning:

Warning: spec.template.spec.containers[0].env[16]: hides previous definition of "LOGICAL_BACKUP_AZURE_STORAGE_ACCOUNT_KEY"

Everything still works so this is a low priority bug.

A check should be added for Azure and GCP in the same way this is done for AWS.

I can fix this in a PR if needed and if I find the time.

FxKu commented 3 months ago

A PR to fix it is more than welcome :+1:

FxKu commented 2 months ago

Fix has been merged

zalando / postgres-operator

Logical backup secret results in duplicate environment keys #2716