zalando / postgres-operator

Postgres operator creates and manages PostgreSQL clusters running in Kubernetes
https://postgres-operator.readthedocs.io/
MIT License
4.38k stars 980 forks source link

remove streams delete and extend unit tests #2737

Open FxKu opened 3 months ago

FxKu commented 3 months ago

2733 fixed a bug with stream duplicates created on every operator restart. To facilitate the cleanup the operator was deleting every extra stream it found based on the filter labels.

In general, the operator should be careful with what it deletes. Therefore this PR removes the delete call again assuming that duplicates should not exist only if somebody adds them manually with the same labels which is unlikely to happen. Sorting is not supported in go client so we would not be able to tell which stream gets synced in the cluster struct (same for deletions).

I have split the update streams unit test to have a dedicated test only for removal.