search

zalando / postgres-operator

Postgres operator creates and manages PostgreSQL clusters running in Kubernetes
https://postgres-operator.readthedocs.io/
MIT License
4.37k stars 980 forks source link

fix(postgres-operator/deployment): Set 'nindent' to 8 for 'extraEnvs' #2783

Closed Mart-Kuc closed 3 weeks ago

Mart-Kuc commented 1 month ago

This PR fixes a template error in postgres-operator/deployment. If you want to use extraEnvs in values.yaml, the current indentation for extraEnvs causes the resulting deployment.yaml to break due to incorrect indentation.

The nindent value has been updated from 12 to 8.

Result with the old values.yaml (nindent 12):

Old-template

Result with the new nindent set to 8: New-template

Bumped Chart.yaml version to 1.13.1 but I'm not sure if it's correct

daleckystepan commented 1 month ago

That would be nice. We also hit that.

FxKu commented 3 weeks ago

Thanks for providing the fix. Could you please keep the version on the Chart.yaml? (see my comment)

FxKu commented 3 weeks ago

:+1: