search

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress
https://opensource.zalando.com/skipper/
Other
3.09k stars 350 forks source link

refactor ioutil usage to io package - Go1.16 #1722

Closed szuecs closed 2 years ago

szuecs commented 3 years ago

https://golang.org/doc/go1.16#ioutil deprecated and we get fs.FS as benefit to better test file integration (read,close,..) in tests

Clivern commented 3 years ago

I am trying to build with go1.16 and skipper fails

➜  $ go version
go version go1.16 darwin/amd64
➜  $ go build skipper.go
# command-line-arguments
./skipper.go:1137:13: o.findAndLoadPlugins undefined (type Options has no field or method findAndLoadPlugins)
szuecs commented 3 years ago

Please create a new issue, instead. Thanks

AlexanderYastrebov commented 3 years ago

@Clivern Hello, you need to use make to build Skipper, see https://github.com/zalando/skipper#working-with-the-code

Clivern commented 3 years ago

Yeah, i extracted the command from Makefile. Thanks @AlexanderYastrebov 

$ go build cmd/skipper/main.go
AlexanderYastrebov commented 2 years ago

Fixed by #1857