search

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress
https://opensource.zalando.com/skipper/
Other
3.12k stars 351 forks source link

Allow open tracing client span name and component tag customization #1798

Open AlexanderYastrebov opened 3 years ago

AlexanderYastrebov commented 3 years ago

Is your feature request related to a problem? Please describe.

Skipper allows customization of the incoming span name https://github.com/zalando/skipper/blob/d0b249a4aa8993a050b87cecc11cc6ca839195a4/proxy/tracing.go#L47-L49

but uses hardcoded outgoing(client) span name (could be changed by tracingSpanName filter) https://github.com/zalando/skipper/blob/2a887863f6875029a8d4ba3aed535efc39156e4a/proxy/proxy.go#L905-L908

and a hardcoded "component" tag https://github.com/zalando/skipper/blob/2a887863f6875029a8d4ba3aed535efc39156e4a/proxy/proxy.go#L1473

Users of Skipper library may want to override outgoing span and component tags names.

Describe the solution you would like Extend open-tracing configuration to allow span and component name customization. An open question is whether related command line flags should be added as well.

Would you like to work on it? Yes

AlexanderYastrebov commented 3 years ago

Component name is also hardcoded in several other places https://github.com/zalando/skipper/blob/2a887863f6875029a8d4ba3aed535efc39156e4a/ratelimit/redis.go#L93 https://github.com/zalando/skipper/blob/2a887863f6875029a8d4ba3aed535efc39156e4a/filters/auth/authclient.go#L52 https://github.com/zalando/skipper/blob/2a887863f6875029a8d4ba3aed535efc39156e4a/filters/auth/grantconfig.go#L177