search

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress
https://opensource.zalando.com/skipper/
Other
3.09k stars 350 forks source link

Specify tracing span kind on creation #3039

Closed AlexanderYastrebov closed 5 months ago

AlexanderYastrebov commented 5 months ago

OpenTelemetry-OpenTracing bridge span kind can not be changed after creation, see https://github.com/open-telemetry/opentelemetry-go/issues/3953

The workaround is to specify span kind on creation which works for both Open Tracing and Open Telemetry bridge spans.

For #2104

szuecs commented 5 months ago

let's land it, no?

RomanZavodskikh commented 5 months ago

:+1:

AlexanderYastrebov commented 5 months ago

Rebased and fixed span creation added by #3034

szuecs commented 5 months ago

:+1:

AlexanderYastrebov commented 5 months ago

:+1: